xwp / wp-dependency-minification

Dependency Minification plugin for WordPress
http://wordpress.org/plugins/dependency-minification/
52 stars 10 forks source link

Adds at-rule handling to CSS compression. #60

Open msigley opened 10 years ago

msigley commented 10 years ago

Properly handles charset, namespace, and import at-rules according to: https://developer.mozilla.org/en-US/docs/Web/CSS/At-rule

Import rules are currently just stripped out of the CSS to prevent issues in the output, but this could be improved by including the contents of the import url and compressing it.

msigley commented 10 years ago

Fixes issue #59.

westonruter commented 10 years ago

@msigley this Compressor.php is actually copied from the Minify project: https://github.com/mrclay/minify/blob/master/min/lib/Minify/CSS/Compressor.php

Can you instead open a PR to apply the change to the file in that project, and we can fold it into Dependency Minification. I wouldn't want the changes to get lost the next time it gets updated.

msigley commented 10 years ago

Thanks I submitted a new pull request to the Minify project. https://github.com/mrclay/minify/pull/101