search

xwp / wp-widget-customizer

[OBSOLETE] Widget Customizer plugin for WordPress (now merged into Core)
http://wordpress.org/plugins/widget-customizer/
54 stars 18 forks source link

Bugfix for handling keypress for available widgets #72

Closed knishiura-lab closed 10 years ago

knishiura-lab commented 10 years ago

It intended that user can walk through available widgets (middle column in screenshot) by pressing up and down key. Thus, when user hit those keys, selection shoudn't be submit. There was bug in this condition check, and tshis PR fix it.

Tested on Firefox on Ubuntu. On Chrome, both new and old code works for whatever reason.

available-widget

westonruter commented 10 years ago

@knishiura-lab Good catch! I merged into the develop branch and this will be included in the next release.

What's your WordPress.org profile/username?

knishiura-lab commented 10 years ago

My username is daisy1754 Thanks!

westonruter commented 10 years ago

@knishiura-lab I can't seem to find a profile at http://profiles.wordpress.org/daisy1754/

knishiura-lab commented 10 years ago

@westonruter Hmm, I misunderstood what is wordpress account. I have gravatar account and it's my profile (http://en.gravatar.com/daisy1754 ). I may have made wordpress account as well when taking gravatar account, but not sure. I'm just trying wordpress locally and don't have my own blog hosted by wordpress. Hope it answers your question :)

westonruter commented 10 years ago

@knishiura-lab ok, you want me to link to your Gravatar profile in the changelog?

knishiura-lab commented 10 years ago

@westonruter Wow, that would be cool! Is it possible to put my github url https://github.com/knishiura-lab instead?

westonruter commented 10 years ago

Happily! Thanks again for your contribution. :bow:

knishiura-lab commented 10 years ago

cool, thanks :smile: