search

xxfxxf / chromiumembedded

Automatically exported from code.google.com/p/chromiumembedded
0 stars 0 forks source link

Cef::UserData V8 attribute visible from JavaScript #316

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The "Cef::UserData" V8 attribute is used for linking user_data to V8 objects 
for C++ bindings. This attribute is currently visible from JavaScript 
applications (obj["Cef::UserData"]). It would be better if this value could be 
completely hidden from the JavaScript side.

Original issue reported on code.google.com by magreenb...@gmail.com on 30 Aug 2011 at 3:38

GoogleCodeExporter commented 9 years ago 
Same for "Cef::Handler" and "Cef::Accessor" (at CEF R275).
I agree, that will be better if this CEF attributes will not configurable and 
not enumerable.

PS:
Also CefV8Value.SetValue method doesn't allow define property with custom 
CefV8PropertyAttribute. I mean that:

// v8.h
class Object : public Value {
 public:
  V8EXPORT bool Set(Handle<Value> key,
                    Handle<Value> value,
                    PropertyAttribute attribs = None);

this method actually hidden by Cef.
This can be very useful to export readonly data and functions to JS.

Original comment by fdd...@gmail.com on 11 Sep 2011 at 1:23

GoogleCodeExporter commented 9 years ago

Original comment by magreenb...@gmail.com on 4 Nov 2011 at 6:21

GoogleCodeExporter commented 9 years ago 
Fixed in revision 358. Adding a PropertyAttribute parameter to SetValue() is 
moved to issue #412.

Original comment by magreenb...@gmail.com on 4 Nov 2011 at 7:35

GoogleCodeExporter commented 9 years ago 
Revision 361 moves CEF V8 internal attributes to hidden values and adds a test 
to verify safety.

Original comment by magreenb...@gmail.com on 7 Nov 2011 at 9:40