xxfxxf / chromiumembedded

Automatically exported from code.google.com/p/chromiumembedded
0 stars 0 forks source link

OnTitleChange() and OnLoadEnd() events should not be raised on provisional load failure #381

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Enter "mailto:" in the address bar and press enter
  - This is reproducible with any external scheme

What is the expected output? What do you see instead?

I expect that CEF will not raise the following events:

CefDisplayHandler::OnTitleChange()
CefLoadHandler::OnLoadEnd()

Instead I see both of these events raised after entering "mailto:".  Note that 
I do not see a CefLoadHandler::OnLoadStart() event, which is expected.

What version of the product are you using? On what operating system?

Revision 283 on Windows XP

Please provide any additional information below.

I don't expect to see the above events to be raised because the content of the 
page is not changing in the case where I enter an external scheme.  
Additionally, since OnLoadEnd() is being raised without an OnLoadStart() event, 
this could result in unexpected behavior for consumers who are expecting both 
to be called during a page load.

Patch is attached

Original issue reported on code.google.com by avivr...@gmail.com on 18 Oct 2011 at 6:12

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks, fixed in revision 332.

Original comment by magreenb...@gmail.com on 21 Oct 2011 at 2:38