search

xxh / xxh-plugin-zsh-ohmyzsh

Oh my zsh plugin for xxh zsh
BSD 2-Clause "Simplified" License
38 stars 20 forks source link

Fix the +e plugins not working #1

Open alfred-chan opened 4 years ago

alfred-chan commented 4 years ago

Replace plugins with plugins_ in env. variable and then eval it as list variable in pluginrc.zsh

anki-code commented 4 years ago

Hello @alfred-chan and welcome! I can repeat this issue:

$ xxh myhost +s zsh +e plugins='(git ubuntu)' +v +e ZSH_THEME='clean'                                                                                                                                                                 
...
...
Entrypoint env: raw=plugins=KGdpdCB1YnVudHUp, name=plugins, value=(git ubuntu)
Entrypoint env: raw=ZSH_THEME=Y2xlYW4=, name=ZSH_THEME, value=clean
Load plugin /home/user/.xxh/.xxh/shells/xxh-shell-zsh/build/zsh-bin/bin/../../../../../plugins/xxh-plugin-zsh-ohmyzsh/build/pluginrc.zsh
[oh-my-zsh] plugin '(git ubuntu)' not found
myhost:~/ $ echo $plugins                                                                                                                                                                                                       
(git ubuntu)
myhost:~/ $

But it looks like the problem is not in this repo. This should be fixed in the zsh shell entrypoint:

https://github.com/xxh/xxh-shell-zsh/blob/master/entrypoint.sh#L56-L66

I'm not the active zsh user so please check my logic.