xxh / xxh-shell-fish

Use the fish shell wherever you go through the SSH without installation on the host.
BSD 2-Clause "Simplified" License
18 stars 12 forks source link

Added xxh-config.fish rc file to source plugins. #5

Closed frederickjh closed 4 years ago

frederickjh commented 4 years ago

Work on #4 to add rc file for loading plugins.

anki-code commented 4 years ago

Good start! I've tested it and it works for sample plugin.

I've created the repo xxh-plugin-fish-ohmyfish. Could you create xxh-plugin for Oh My Fish to proof the solution?

anki-code commented 4 years ago

@frederickjh please look on this comment - https://github.com/fish-shell/fish-shell/issues/6829#issuecomment-605661229

I think you can replace:

$fish_bin $XXH_HOME/.xxh/shells/xxh-shell-fish/build/xxh-config.fish
$fish_bin "${EXECUTE_COMMAND[@]}"  # $EXECUTE_FILE

To:

$fish_bin -i -C "source $XXH_HOME/.xxh/shells/xxh-shell-fish/build/xxh-config.fish" "${EXECUTE_COMMAND[@]}"  # $EXECUTE_FILE

It is more naturally simulate the "rc file pre execution".

frederickjh commented 4 years ago

I replaced those two lines of code with one and tested, however to make it easier for those later reading the code I used the long options.

frederickjh commented 4 years ago

I've created the repo xxh-plugin-fish-ohmyfish. Could you create xxh-plugin for Oh My Fish to proof the solution?

Maybe later, I am more interested to get a plugin working for Fisher another package manager for the Fish Shell, so that I can get this to a usable state for me.

anki-code commented 4 years ago

Fisher

Created: https://github.com/xxh/xxh-plugin-fish-fisher :)