Version field error for 4.1.3 .deb package

KRTac commented 2 years ago

gotop version:

4.1.3

OS/Arch:

5.13.0-37-generic GNU/Linux

Terminal emulator:

any

Any relevant hardware info:

any

tmux version:

no

I get the following error while installing the deb:

dpkg: error processing archive gotop_v4.1.3_linux_amd64.deb (--unpack):
 parsing file '/var/lib/dpkg/tmp.ci/control' near line 2 package 'gotop':
 'Version' field value 'vv4.1.3+git': version number does not start with digit

xxxserxxx commented 2 years ago

Duplicate #206, #209. Leaving this one open until I release a new version so folks can see it.

KRTac commented 2 years ago

Didn't search for the issue well enough, sry.

FYI, if you're doing the unpack-fix version-repack fix, you can also move the man8 directory inside a man dir, to fix the man page.

Harliff commented 2 years ago

Just faced this error on Debain 11 (amd64).

TheProjectsGuy commented 2 years ago

I got a similar error on my Linux Mint system. The system details are as follows.

uname -a

Linux talo 5.4.0-113-generic #127-Ubuntu SMP Wed May 18 14:30:56 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

lsb_release -a

No LSB modules are available.
Distributor ID: Linuxmint
Description:    Linux Mint 20.3
Release:    20.3
Codename:   una

I ran the following commands (inspired from here)

Download the file

cd ~/Downloads/
wget https://github.com/xxxserxxx/gotop/releases/download/v4.1.3/gotop_v4.1.3_linux_amd64.deb

Unpack the file and open the `DEBIAN/control file (which contains the version)

dpkg-deb -vR ./gotop_v4.1.3_linux_amd64.deb ./gotop/
cd ./gotop/DEBIAN
vi ./control

Change the version line From
```
Version: vv4.1.3+git
```
To
```
Version: 4.1.3+git
```

Rebuild the package and install it

cd ~/Downloads
dpkg-deb -b ./gotop gotop_fixed_v4.1.3_linux_amd64.deb
sudo dpkg -i ./gotop_fixed_v4.1.3_linux_amd64.deb

The last command above runs perfectly on my system.

dnet890 commented 2 years ago

I can confirm that the problem exists on Ubuntu 20.04 and 22.04.

dschaper commented 2 years ago

Looks like the build isn't set for a manual kickoff. Happy to PR the change to allow that so you can manually run a release instead of waiting for the next release.

https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow#configuring-a-workflow-to-run-manually

xxxserxxx commented 2 years ago

Should be fixed by f433901 (code changes in github.com/xxxserxxx/actions/entrypoint.sh, which mangle the version so that dpkg will accept it.

xxxserxxx / gotop