xxxserxxx / gotop

A terminal based graphical activity monitor inspired by gtop and vtop
Other
2.69k stars 138 forks source link

Fix build failure on riscv64 caused by missing syscall #218

Open CamberLoid opened 2 years ago

CamberLoid commented 2 years ago

Hello. This is Camber from Anthon community and I am working on maintaining go-based packages in our distro's repository including gotop. I encountered a build failure on our riscv64 target and managed to write a patch for the issue.

On RISC-V 64-bit linux systems, syscall dup2() is not available, therefore syscall.Dup2 will become undefined and gotop will fail to be built from source. This patch updates building target of logging/logging_{other,arm64} and renames them based on syscall used.

I can personally confirm that the patch will solve aforementioned issue.

Reference: