search

xxxserxxx / gotop

A terminal based graphical activity monitor inspired by gtop and vtop
Other
2.76k stars 140 forks source link

gotop no longer works in urxvt, works fine in xterm #227

Closed jgb closed 7 months ago

jgb commented 2 years ago
gotop version:

gotop v4.1.4 (20220715T163833)

OS/Arch:

Debian bookworm 5.18.0-2-amd64 GNU/Linux

Terminal emulator:

rxvt-unicode

When I start gotop in rxvt-unicode, it shows the help window immediately explaining the shortcuts. The only thing I can do then is hit q to exit, and gotop exists. When I start gotop on the same machine in xterm, everything works fine. The previous version didn't have this problem with urxvt.

PieterjanMontens commented 2 years ago

Same here, same version and similar environment. This is what it looks like if I run gotop -l kitchensink :

gotop_urxvt

RockyBukake commented 2 years ago

Same problem, exporting TERM=screen-256color "fixed" this issue

jgb commented 2 years ago

@xxxserxxx can confirm the latest 4.2.0 is still completely broken on rxvt.

xxxserxxx commented 2 years ago

@jgb Thanks, can you report what your TERM settings are, and whether @RockyBukake's hack works for you?

jgb commented 2 years ago

@xxxserxxx my TERM is set to rxvt-unicode-256color. Setting the TERM to something else like @RockyBukake suggests does fix the problem.

xxxserxxx commented 2 years ago

That's a huge help, actually. Thanks. I'll bump this upstream to termui.

Lightsockie commented 1 year ago

Been getting this as well, and the same TERM= fix above works for me too. 

gotop v4.2.0 (Hadean)
rxvt-unicode (urxvt) v9.31 - released: 2023-01-02 (but it's happened on previous builds)
TERM=rxvt-unicode-256color` (default for me as well)

Looks like upstream is abandonware -- or, at least I can't find any maintained fork. My tmux, which is where I run gotop 95% of the time anyway, is already setting a working TERM. So it's kinda a non-issue for me.

But I've come this far and am kinda curious whats going on (guessing bad escape sequence that just so happens to open up help?). Is there an issue somewhere I can watch @xxxserxxx?

xxxserxxx commented 1 year ago

There haven't been any changes in termui in a while, but TBF, things are slow in gotop as well. The curse of the single-contributor project, I guess.

It might not be a termui issue. It only seems to happen with rxvt-unicode and the rxvt-unicode terminfo combined -- the terminfo alone doesn't cause it, nor does urxvt with a different terminfo. I think you're probably right: one of the control characters is probably not being consumed properly by the terminal and is being passed through to gotop.

On Arch, ncurses owns many of the terminfos, but rxvt-unicode is owned by the rxvt-unicode package. The repository for rxvt-unicode is in CVS(!!). The issue may be anywhere between there and gotop; sorry that I don't have any better instinct on where to start.