search

xxxserxxx / gotop

A terminal based graphical activity monitor inspired by gtop and vtop
Other
2.76k stars 140 forks source link

$TERM rendering bug #235

Closed anasrar closed 1 year ago

anasrar commented 2 years ago

some rendering bug occur in terminal because $TERM

alacritty

image process cursor not visible, try run with TERM=xterm-kitty gotop

kitty

image process cursor render bug, try run with TERM=xterm gotop

tmux

if you get some error like this in tmux session

07:55:56 remote.go:74: Remote: no remote URL provided; disabling extension
07:55:56 temp_nix.go:35: error opening smart info for sda: unknown drive type
07:55:56 temp_nix.go:35: error opening smart info for sdb: unknown drive type
termbox: error while reading terminfo data: termbox: unsupported terminal

it because gotop not support your current session $TERM in tmux, try run with TERM=xterm-kitty gotop

gotop version:

gotop v4.1.4 (20220715T163833)

OS/Arch:

5.19.5-arch1-1 GNU/Linux

Terminal emulator:

alacritty and kitty

Any relevant hardware info:

-

tmux version:

tmux 3.3a

cmalvi commented 2 years ago

same with gnome terminal

rare-magma commented 2 years ago

I believe this bug first appeared after the update of some libraries done in https://github.com/xxxserxxx/gotop/pull/221/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6

KBeDevel commented 1 year ago

I have this issue in v4.2.0.

My environment:

Terminals: Konsole, Kitty OS: Fedora 38 KDE Spin Install method: Homebrew

gardockt commented 10 months ago

There was no release since the fix was merged, so v4.2.0 is still affected. Currently the only way to get the fixed version is to build the program manually.

KBeDevel commented 10 months ago

@gardockt Yes, local build using latest commit (3e50a670474909c72892d05f5715c2c28680005d) seems to work perfect.

xxxserxxx commented 10 months ago

Yeah, I will probably do a minor version bump release for this shortly.