Closed gardockt closed 1 year ago
Running the rather byzantine cross-platform build process fails compiling smart.go
on Darwin. This may not be a result of the patch, but I have to dig into and resolve it before I can merge this.
Thanks for the well-written PR; I agree with the approach as a stop-gap for resolving the conflicts.
Everything seems to build now, so merged and pushed. Thanks again.
termui
is incompatible with the latest version oftermbox-go
, which caused highlighted text to disappear (#226). The reason behind it is thattermui
converts each terminal cell's desired colors and modifiers totermbox-go
format, using the formula present inrender.go
:termbox-go
then reads the modifiers by comparing them with defined constants. Versionv0.0.0-20190121233118-02980233997d
, marked astermui
's dependency inside itsgo.mod
, contains these definitions:However,
v1.1.1
, marked as minimum required version bygotop
, had the code above changed to:As can be seen, what was
AttrReverse
inv0.0.0-20190121233118-02980233997d
, becameAttrHidden
inv1.1.1
. It's also not hard to notice why changingtermui
'sReverseModifier
constant to1 << 15
insidegotop
's code worked as a workaround.termui
correctly marked minimum required version oftermbox-go
asv0.0.0-20190121233118-02980233997d
, but dependency bump in c3aeb753d9355fcf3d5e6cbbdb892e61470e5abf caused a compatibility issue. Instead of removingtermbox-go
fromgo.mod
and lettingtermui
manage it, I lowered the minimum required version tov0.0.0-20200418040025-38ba6e5628f1
in order to avoid possible regression on FreeBSD (#95).Fixes #226 Fixes #235