search

xy2z / dopenote

📝 Self-hosted modern webapp for notes - Free and open source - (WORK IN PROGRESS)
https://dopenote.gitbook.io/docs/
GNU General Public License v3.0
24 stars 9 forks source link

2FA - Google Authenticator - Enable/disable #110

Open xy2z opened 4 years ago

xy2z commented 4 years ago

https://github.com/antonioribeiro/google2fa-laravel

Under "User settings" it should be possible to enable/disable 2FA using Google Authenticator. When disabling, user must enter the current 2FA code before succeeding.

Let me know if you have any questions

finalbytes commented 4 years ago

Hey, I want to see if I can help you to disable the Google Authenticator in the settings page (# 110). Shall I open a PR?

xy2z commented 4 years ago

@finalbytes not disable, enable :) yes please

Edit: oh you meant the disable part. The enable part is part of this issue and im not sure it makes sense to split these 2 up?

finalbytes commented 4 years ago

Okay, I think I misunderstood you. But I understand from this that you want to have the 2FA built into your application (dopenote). And if you want to switch it off that you also use the 6-digit code of your 2FA? Do I understand you better? Then it seems useful that I first implement this in the application, and then make the addition for switching off with code. Let me know if you actually mean this.

xy2z commented 4 years ago

@finalbytes yes exactly. Per user.

finalbytes commented 4 years ago

I'll implement this feature for you!

xy2z commented 4 years ago

@finalbytes awesome :)

xy2z commented 4 years ago

@finalbytes how's it going? 😃