search

xy2z / dopenote

📝 Self-hosted modern webapp for notes - Free and open source - (WORK IN PROGRESS)
https://dopenote.gitbook.io/docs/
GNU General Public License v3.0
24 stars 9 forks source link

Undo & Redo bugs when changing notes (History) #63

Closed xy2z closed 4 years ago

xy2z commented 5 years ago

It uses history for the other notes... So maybe a new editor instance per note?

Reproduce

  1. Enable History in tiptap (resources/js/components/EditorContent.vue file)
  2. run npm run dev (or npm run watch)
  3. Login on Dopenote
  4. Edit note content
  5. Change note
  6. Press CTRL+Z and content changes to the previos note content.

History should be per note. I'm not sure what a good solution to this bug is, so for now I've disabled history...

xy2z commented 4 years ago

Implemented custom undo/redo functionality. This will have to be tested alot before release

xy2z commented 4 years ago

Seems to work for now. However, this (probably) needs to be changed before moving to sockets because it probably won't work with multiple users at the same time. Prosemirrors build in history should take care of that. So I've made a feature request for a clear/reset history method in prosemirror.

Closing this as it seems to work all right for v1.0