fix tree builder usage unsupported by Symfony 5 (no root node)

xyNNN / GoogleTagManagerBundle

Google Tag Manager Bundle for Symfony 2

https://github.com/xyNNN/GoogleTagManagerBundle

GNU Lesser General Public License v3.0

27 stars 15 forks source link

fix tree builder usage unsupported by Symfony 5 (no root node) #33

Closed conciergerie-numerique closed 4 years ago

conciergerie-numerique commented 4 years ago

Fixing two deprecation warnings:

A tree builder without a root node is deprecated since Symfony 4.2 and will not be supported anymore in 5.0.
The "Symfony\Component\Config\Definition\Builder\TreeBuilder::root()" method called for the "google_tag_manager" configuration is deprecated since Symfony 4.3, pass the root name to the constructor instead.

xyNNN commented 4 years ago

Thank you very much for your contribution! Could you please merge again the master into it, I've adjusted the Travis CI configuration so the memory limit issue should disappear. Afterwards I can merge it :)

conciergerie-numerique commented 4 years ago

Thank you very much for this bundle! I've pulled the master, everything is merged.

xyNNN commented 4 years ago

Tagged a new release https://github.com/xyNNN/GoogleTagManagerBundle/releases/tag/2.5.0