Allow changing GoogleTagManager service status and id after init

xyNNN / GoogleTagManagerBundle

Google Tag Manager Bundle for Symfony 2

https://github.com/xyNNN/GoogleTagManagerBundle

GNU Lesser General Public License v3.0

27 stars 15 forks source link

Allow changing GoogleTagManager service status and id after init #36

Closed ialvesdasilva closed 4 years ago

ialvesdasilva commented 4 years ago

Allow changing GoogleTagManager service status and id after initialization This allows us to :

Support enabling/disabling gtm service by page in same website
Support injecting different gtm id by page in same website
Handle multiple gtm id for one website

xyNNN commented 4 years ago

Thanks for your contribution. I think it would be better to define two more speakable methods like enable() and disable() to make the API more robust. What do you think?

ialvesdasilva commented 4 years ago

You mean replacing setEnabledStatus method by those two methods. You're right that would be better. I'll add a new commit to my Pull request Thank you

xyNNN commented 4 years ago

See https://github.com/xyNNN/GoogleTagManagerBundle/releases/tag/2.8.0

ialvesdasilva commented 4 years ago

Thank you again Could you please also update the tag on packagist database? I can't see the new tag yet

xyNNN commented 4 years ago

Oh sorry. Normally this should be updated automatically, I've triggered the update, see https://packagist.org/packages/xynnn/google-tag-manager-bundle

ialvesdasilva commented 4 years ago

No problem 👍 thanks