xyNNN / GoogleTagManagerBundle

Google Tag Manager Bundle for Symfony 2
https://github.com/xyNNN/GoogleTagManagerBundle
GNU Lesser General Public License v3.0
27 stars 15 forks source link

Using the "Twig_Extension" class is deprecated since Twig version 2.7 #38

Open poaq opened 4 years ago

poaq commented 4 years ago

any plan to update it?

solution: Twig\Extension\AbstractExtension intsead of twig_extension Twig\TwigFunction instead of Twig_SimpleFunction

create yaml file for config: google_tag_manager.yaml (this info is lack in docs)

jkabat commented 3 years ago

@xyNNN would update of twig classes be accepted? That means dropping support for old symphony versions and allow Twig v3.

xyNNN commented 3 years ago

@jkabat

We can drop it, sure. My suggestion is to update twig as dependency and create a new major release (3.x) for the new Symfony version, so we can support the old versions with the 2.x release. Feel free to make a pull request 👍 Thanks!