Hotfix for symfony 5 and twig over version 2.7

xyNNN / GoogleTagManagerBundle

Google Tag Manager Bundle for Symfony 2

https://github.com/xyNNN/GoogleTagManagerBundle

GNU Lesser General Public License v3.0

27 stars 15 forks source link

Hotfix for symfony 5 and twig over version 2.7 #39

Closed poaq closed 4 years ago

xyNNN commented 4 years ago

Thanks for your pull request. Is this changes backwards compatible with Symfony below the latest version? I haven't found the time yet to verify this.

poaq commented 4 years ago

With symfony version for sure. But it replace OLD methods in twig wich are deprecated and deleted in twig version over 2.7.

xyNNN commented 4 years ago

With symfony version for sure. But it replace OLD methods in twig wich are deprecated and deleted in twig version over 2.7.

Okay. Then it would make more sense to require also twig as minimum 2.7 to ensure that we don't introduce with the next minor release a breaking change.