search

xyNNN / GoogleTagManagerBundle

Google Tag Manager Bundle for Symfony 2
https://github.com/xyNNN/GoogleTagManagerBundle
GNU Lesser General Public License v3.0
27 stars 15 forks source link

extending ContainerAware is deprecated since symfony version 2.8 #6

Closed toooni closed 8 years ago

xyNNN commented 8 years ago

Sorry, I've missed this pull request. Do you think it makes sense to update the version constraint of the symfony components to greater than 2.8 and create a new release for this update to prevent breaking changes? If yes, could you update the constraints in the composer.json?

Thank you @toooni

xyNNN commented 8 years ago

I've fixed the failed tests on Travis CI in the current master branch. Could you rebase your pull request? ;) See my commit https://github.com/xyNNN/GoogleTagManagerBundle/commit/13da7110a98f2452c744b54360aef4daaa6eec49

toooni commented 8 years ago

@xyNNN i rebased the PR and added the symfony constraints (which totally makes sense, sorry). I took the liberty to change the package version in readme to version ~2.0 - You can tell if you want to change this.

xyNNN commented 8 years ago

Great! Thank you very much @toooni - I will prepare the new release today in the evening!