search

xyNNN / GoogleTagManagerBundle

Google Tag Manager Bundle for Symfony 2
https://github.com/xyNNN/GoogleTagManagerBundle
GNU Lesser General Public License v3.0
27 stars 15 forks source link

Only append container in master request #7

Closed fbourigault closed 8 years ago

fbourigault commented 8 years ago

Previously, when rendering an exception, as the HttpKernel use a sub-request to handle the exception, the container was injected twice, for the sub-request and the master request.

I don't think this is a breaking change as appending the same container twice is always wrong.

xyNNN commented 8 years ago

You're right, I will give you feedback a bit later, currently I'm busy. Thank you for contributing @fbourigault

fbourigault commented 8 years ago

Thank you for the merge and the release.

xyNNN commented 8 years ago

Thank you for contributing :)