xyb3rt / sxiv

Simple X Image Viewer
GNU General Public License v2.0
1.82k stars 261 forks source link

removed unnecessary explicit case for escape key being pressed and... #428

Open Sketch98 opened 3 years ago

Sketch98 commented 3 years ago

...added option to allow multiple inputs to the external key handler at once.

The condition at main.c line 589-590 if (ksym == XK_Escape && MODMASK(kev->state) == 0) { extprefix = False; is unnecessary because extprefix is set to false on line 593 no matter which key is pressed, including escape. Also, explicitly checking for XK_Escape means the user can't bind any commands to the escape key (i prefer to bind esc to 'exit without output' if possible). Also I added one_keyhandler_cmd, but the diff for config.def.h explains that well enough.