search

xybu / onedrive-d-old

Microsoft OneDrive client on Linux.
http://xybu.me/projects/onedrive-d/
GNU Lesser General Public License v3.0
820 stars 143 forks source link

parially refactoring to pep 8 and misspell correction #116

Closed kissarat closed 9 years ago

kissarat commented 9 years ago

I'll continue if you interesting

xybu commented 9 years ago

Did you do those by hands? If so I am really really sorry... I have abandoned the code base in 1.0-dev...

And I personally prefer tabs over spaces because it saves me some keystrokes either when indenting or unindenting...

For misspells, I appreciate it if you can point them out so I can check if same mistakes exist in future branch.

Sincerely,Xiangyu Bu

Date: Tue, 24 Feb 2015 10:34:42 -0800 From: notifications@github.com To: onedrive-d@noreply.github.com Subject: [onedrive-d] parially refactoring to pep 8 and misspell correction (#116)

I'll continue if you interesting

You can view, comment on, or merge this pull request online at: https://github.com/xybu/onedrive-d/pull/116

Commit Summary

parially refactoring to pep 8 and misspell correction

File Changes

M
.gitignore
(4)

M
onedrive_d/config.py
(151)

M
onedrive_d/daemon.py
(1551)

M
onedrive_d/logger.py
(148)

Patch Links:

https://github.com/xybu/onedrive-d/pull/116.patch https://github.com/xybu/onedrive-d/pull/116.diff

— Reply to this email directly or view it on GitHub.

kissarat commented 9 years ago

Run flake8 and see ) https://pypi.python.org/pypi/flake8 Spaces are the preferred indentation method. Tabs should be used solely to remain consistent with code that is already indented with tabs. Python 3 disallows mixing the use of tabs and spaces for indentation. https://www.python.org/dev/peps/pep-0008/#tabs-or-spaces "something == None" using instead of "somthing is None" ... Why do you not use JetBrains PyCharm?

xybu commented 9 years ago

Ptr == None is wrong. I agreed. Will fix in "future" branch.

I already used tabs so I guess I am fine with that rule. I don't have mixing of tabs and spaces I think.

Will try out flake8 and fix tabs stuff at some time.

PyCharm is too fat for me. You know what... Ashamed to say it... I use mousepad and sometimes vim...

Sent from my Windows Phone

From: Taras Labiakmailto:notifications@github.com Sent: ‎2/‎24/‎2015 3:34 PM To: xybu/onedrive-dmailto:onedrive-d@noreply.github.com Cc: Xiangyu Bumailto:xybu92@live.com Subject: Re: [onedrive-d] parially refactoring to pep 8 and misspell correction (#116)

Run flake8 and see ) https://pypi.python.org/pypi/flake8 Spaces are the preferred indentation method. Tabs should be used solely to remain consistent with code that is already indented with tabs. Python 3 disallows mixing the use of tabs and spaces for indentation. https://www.python.org/dev/peps/pep-0008/#tabs-or-spaces "something == None" using instead of "somthing is None" ... Why do you not use JetBrains PyCharm?

Reply to this email directly or view it on GitHub: https://github.com/xybu/onedrive-d/pull/116#issuecomment-75839891

kissarat commented 9 years ago

So you can reject this pull request. I'll refactor future branch and don't replace tabs with spaces

xybu commented 9 years ago

Hold on for now. I have local stuff that hasn't been pushed to "future" :)

Sent from my Windows Phone

From: Taras Labiakmailto:notifications@github.com Sent: ‎2/‎24/‎2015 3:47 PM To: xybu/onedrive-dmailto:onedrive-d@noreply.github.com Cc: Xiangyu Bumailto:xybu92@live.com Subject: Re: [onedrive-d] parially refactoring to pep 8 and misspell correction (#116)

So you can reject this pull request. I'll refactor future branch and don't replace tabs with spaces

Reply to this email directly or view it on GitHub: https://github.com/xybu/onedrive-d/pull/116#issuecomment-75842199

kissarat commented 9 years ago

When will you push your changes?