logging broken by commit 7b3ce394c9864a65aba79d84e679dc558c74fc4f

[ewann]

commit 7b3ce394c9864a65aba79d84e679dc558c74fc4f appears to have broken logging. Steps to reproduce (assumes you already have successfully installed and configured onedrive-d at least once):

cd ~/ onedrive-d stop sudo pip3 uninstall onedrive-d git clone https://github.com/xybu/onedrive-d.git cd onedrive-d sudo python3 setup.py install sudo python3 setup.py clean sudo touch /var/log/onedrive_d.log sudo chown whoami /var/log/onedrive_d.log onedrive-d start

at this point, onedrive-d is running, but isn't logging anything to /var/log/onedrive_d.log

The following actions result in a version where logging works: cd ~/ onedrive-d stop sudo pip3 uninstall onedrive-d git clone https://github.com/xybu/onedrive-d.git cd onedrive-d git checkout c255c089f7e986c26d292ff373e0fb5503a43006 sudo python3 setup.py install sudo python3 setup.py clean sudo touch /var/log/onedrive_d.log sudo chown whoami /var/log/onedrive_d.log onedrive-d start

at this point, logging is working again

[ewann]

hi @CGenie

Are you able to provide any input about commit https://github.com/xybu/onedrive-d/commit/7b3ce394c9864a65aba79d84e679dc558c74fc4f ? As it seems to break logging I'm inclined to revert it, but maybe you have some comment that means it should stay?

[CGenie]

Please take a look at line https://github.com/xybu/onedrive-d/commit/7b3ce394c9864a65aba79d84e679dc558c74fc4f#diff-e83c4d74c3c9d20bc46e24f26ded5dbfR169 There, ConfigSet.logger is used, that's why I added logger to this class' attributes.

[Dr-Xperience]

Same here logging broken. Still not working after commit 62a0733d9a49e7703b5ddbff6d883f4eb28c4c52

[technic-tec]

Same here. Still not working after commit 3f2e524031ea86c5e6f5385cdab591a130a292ad.

@CGenie I tried replacing ConfigSet.logger with get_logger(), and reverting 7b3ce394c9864a65aba79d84e679dc558c74fc4f, then the logging works ok for me.