xybu / onedrived-dev

A Microsoft OneDrive client for Linux, written in Python3.
https://github.com/xybu/onedrived-dev
MIT License
705 stars 78 forks source link

Add example to selective sync in the README #109

Closed jonnius closed 5 years ago

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-5.009%) to 46.831% when pulling 21e091be471158ba773fc102d047d8184fb63f41 on jonnius:master into 4f24e4f3b2344ef5cdd9d167913bf32e6419a39b on xybu:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-5.009%) to 46.831% when pulling 21e091be471158ba773fc102d047d8184fb63f41 on jonnius:master into 4f24e4f3b2344ef5cdd9d167913bf32e6419a39b on xybu:master.

codecov-io commented 6 years ago

Codecov Report

Merging #109 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #109   +/-   ##
=======================================
  Coverage   49.46%   49.46%           
=======================================
  Files          38       38           
  Lines        2228     2228           
  Branches      320      320           
=======================================
  Hits         1102     1102           
  Misses       1073     1073           
  Partials       53       53

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4f24e4f...21e091b. Read the comment docs.

jonnius commented 6 years ago

Coverage Status

Coverage decreased (-5.009%) to 46.831% when pulling 21e091b on jonnius:master into 4f24e4f on xybu:master.

What does that mean?

jakebrinkmann commented 5 years ago

@jonnius since I had to dig in to find it out, I think you should mention where this information should be placed, e.g.

# When creating a new drive, include a Drive Specific ignore file
onedrived-pref drive set --ignore-file $HOME/.config/onedrived/ignore_v2.txt

It might make sense to include a simpler example, too. e.g.

# To exclude both "Desktop" and "Path With Spaces" from sync:
/Desktop
/Path\ With\ Spaces

(RE:"Coverage Decreased" the project must not ignore *.md files, and because of that your addition of text reduced the overall percentage of the project covered by unit-testing. Notice the CodeCov report shows no change, which seems more accurate)

jonnius commented 5 years ago

@jakebrinkmann sorry for replying late. Would you like to improve it yourself?

jakebrinkmann commented 5 years ago

@jonnius no worries, I only wanted to provide you some feedback for consideration. I found your modification helpful, so thank you!