xybu / onedrived-dev

A Microsoft OneDrive client for Linux, written in Python3.
https://github.com/xybu/onedrived-dev
MIT License
706 stars 78 forks source link

Uploading Large File Fails in Python 3.3 #87

Open splineGear opened 6 years ago

splineGear commented 6 years ago

Hello, In upload_file.py the 2nd paramater on this line appears to be extraneous:

returned_item = item_request_call(self.repo, item_request.upload_async,
    local_path=self.local_abspath, upload_status=self.update_progress)

Referring to https://github.com/OneDrive/onedrive-sdk-python/blob/master/src/python3/request/item_request_builder.py , only the path is required:

    def upload(self, local_path):
        """Uploads the file using PUT

        Args:
            local_path (str): The path to the local file to upload.

        Returns: 
            The created entity.
        """
        return self.content.request().upload(local_path)

Removing upload_status=self.update_progress from the calling function allowed uploads to work for me. I am running Python 3.3.2+ .

Thanks, gearHed

derrix060 commented 6 years ago

Can you provide more details about what is the error and why changing it will work?