xyflow / xyflow

React Flow | Svelte Flow - Powerful open source libraries for building node-based UIs with React (https://reactflow.dev) or Svelte (https://svelteflow.dev). Ready out-of-the-box and infinitely customizable.
https://xyflow.com
MIT License
25.38k stars 1.63k forks source link

Some edges disappear after updating from v11.4.0 to v11.5.6 #2909

Closed matthiasadriaens closed 1 year ago

matthiasadriaens commented 1 year ago

Describe the Bug

After updating from v11.4.0 to v11.5.6 some edges in our flow dissappeared. Did not find any warnings or errors in the console. Was solved by downgrading again to v11.4.0

Am happy to debug further if you guys want and give me some instructions.

flow in v11.4.0:

Screenshot 2023-03-10 at 14 34 24

flow in v11.5.6 : Screenshot 2023-03-10 at 14 34 56

PS: reactflow is AWESOME

Your Example Website or App

No response

Steps to Reproduce the Bug or Issue

package.json

{
  "name": "schuilenburg-roasthubs",
  "version": "0.1.0",
  "private": true,
  "scripts": {
    "start": "react-scripts start",
    "build": "react-scripts build",
    "test": "react-scripts test",
    "client:check-translation": "./node_modules/.bin/i18next-scanner src/**/*.{ts,tsx}"
  },
  "eslintConfig": {
    "extends": "react-app"
  },
  "browserslist": {
    "production": [
      ">0.2%",
      "not dead",
      "not op_mini all"
    ],
    "development": [
      "last 1 chrome version",
      "last 1 firefox version",
      "last 1 safari version"
    ]
  },
  "dependencies": {
    "@chakra-ui/icons": "2.0.4",
    "@chakra-ui/react": "2.2.4",
    "@emotion/react": "^11.5.0",
    "@emotion/styled": "^11.3.0",
    "@hello-pangea/dnd": "^16.0.0",
    "@heroicons/react": "^2.0.13",
    "@mui/material": "^5.8.2",
    "@types/react-datepicker": "^4.4.2",
    "@types/react-table": "^7.7.12",
    "dagre": "0.8.5",
    "date-fns": "2.25.0",
    "file-saver": "^2.0.5",
    "formik": "2.2.9",
    "framer-motion": "7.0.0",
    "highcharts": "^10.3.1",
    "highcharts-react-official": "^3.1.0",
    "http-proxy-middleware": "2.0.1",
    "i18next": "21.3.3",
    "i18next-browser-languagedetector": "6.1.2",
    "i18next-http-backend": "1.3.1",
    "jspdf": "2.4.0",
    "jspdf-autotable": "3.5.21",
    "qrcode": "1.4.4",
    "react": "^18.2.0",
    "react-colorful": "^5.6.1",
    "react-datepicker": "^4.8.0",
    "react-detect-offline": "^2.4.5",
    "react-dom": "^18.2.0",
    "react-error-boundary": "3.1.3",
    "react-helmet": "6.1.0",
    "react-helmet-async": "^1.3.0",
    "react-i18next": "11.18.1",
    "react-icons": "4.3.1",
    "react-router-dom": "6.3.0",
    "react-scripts": "5.0.1",
    "react-select": "^5.1.0",
    "react-table": "^7.7.0",
    "reactflow": "11.4.0",
    "recharts": "2.1.12",
    "socket.io-client": "4.2.0",
    "web-vitals": "2.1.2",
    "yup": "0.32.11",
    "zustand": "^3.7.1"
  },
  "devDependencies": {
    "@testing-library/jest-dom": "5.14.1",
    "@testing-library/react": "13.3.0",
    "@testing-library/user-event": "13.5.0",
    "@types/dagre": "^0.7.48",
    "@types/file-saver": "^2.0.5",
    "@types/jest": "27.0.2",
    "@types/node": "16.9.4",
    "@types/qrcode": "1.4.1",
    "@types/react": "^18.0.15",
    "@types/react-detect-offline": "^2.4.1",
    "@types/react-dom": "^18.0.6",
    "@types/react-helmet": "6.1.4",
    "@types/react-router-dom": "5.3.3",
    "@types/recharts": "^1.8.23",
    "i18next-scanner": "3.1.0",
    "msw": "0.35.0",
    "typescript": "4.4.4"
  },
  "proxy": "http://localhost:3001/"
}

Expected behavior

For all the edges to be rendered

Screenshots or Videos

No response

Platform

Additional context

No response

moklick commented 1 year ago

do you get any warnings?

matthiasadriaens commented 1 year ago

As far as i could see, i did not get any warnings.

moklick commented 1 year ago

the edge renderer is a bit more strict now. whenever you have multiple handles you need to have a matching sourcheHandle/ targetHandle. I will revert this behaviour since it makes too many problems. The next release should work for you again without changing anything.

matthiasadriaens commented 1 year ago

Okay, thanks a lot @moklick , will check and report back!

moklick commented 1 year ago

should work with 11.6.0. Can you check?

matthiasadriaens commented 1 year ago

Yes, awesome! Working again.

moklick commented 1 year ago

cool :)