search

xyhp915 / logseq-fenced-code-plus

A Logseq plugin for missing types of fenced code 🚀
MIT License
108 stars 17 forks source link

Fix light/dark theme support for echarts #52

Closed swarminglogic closed 3 months ago

swarminglogic commented 3 months ago

Fixes issue described in https://github.com/xyhp915/logseq-fenced-code-plus/issues/51

swarminglogic commented 3 months ago

The pull request fixes the current theming support, which seemed to be mostly there. I also force the background to be transparent. A better approach might have been to only set this if the echarts snipped doesn't explicitly set it.

Just an FYI, I'm not particularly familiar with neither javacript, npm, react, or LogSeq plugin integration for that matter. So, please review the changes with that in mind.

Here is the light/dark themes, which updates correctly when the user changes Light/Dark theme of logseq: image image