Adjusting volume in paused mode plays sounds - Githubissues

xyl0n / coffee-shop

4 stars 1 forks source link

Adjusting volume in paused mode plays sounds #3

Closed xyl0n closed 9 years ago

xyl0n commented 9 years ago

If the application is paused, then adjusting any volumes starts up the sounds. However, it does not change the icon on the play/pause button, which is confusing.

Fixes:

Queue volume to be changed and then play sounds with new volume [ Ideal ]
Change the icon on the button and set the application state

For the 1st option, it could be done as follows:

Restart the mplayer with the new volume and seek to the last position (probably a bad idea)
Create a queue of commands that need to be given to mplayer for when the user unpauses (might work)

xyl0n commented 9 years ago

Fixed (kind of) by using the 'pausing_keep' option when giving commands to mplayer. This pauses ASAP if the player was already in a paused state. Also changed the value-changed signals to button-release-events since mplayer seems to be slow at setting volumes, so it leaves a small gap before pausing, which is more noticable when sliding the slider. As a result, we now only set the volume when the user releases the button.