search

xyncro / chiron

JSON for F#
https://xyncro.tech/chiron
MIT License
173 stars 41 forks source link

Setting minimum FSharp.Core to 4.3.4 #100

Closed ninjarobot closed 5 years ago

ninjarobot commented 5 years ago

Targeting lower FSharp.Core version as specified in the Engineering Guidance.

As of February 2018 new editions of F# libraries should generally do the following:

  • Be netstandard1.6, or netstandard2.0 with an additional .NET Framework 4.5 (net45) build
  • Use FSharp.Core nuget 4.2.3 (assembly version 4.4.1.0) or 4.3.3 (assembly version 4.4.3.0)
ctaggart commented 5 years ago

I think the FSharp.Core dependency should be set to FSharp.Core 4.3.4. https://github.com/fsharp/fsharp.github.io/pull/89#issuecomment-426507365

cartermp commented 5 years ago

I was convinced that 4.3.4 is appropriate due to issues in some tools that place a hard requirement on earlier versions of the binary.