search

xyncro / chiron

JSON for F#
https://xyncro.tech/chiron
MIT License
173 stars 41 forks source link

Remove direct dependence on Aether #68

Closed neoeinstein closed 5 years ago

neoeinstein commented 8 years ago

Chiron will still provide Aether-compatible optics for consumption by others, but shouldn't directly depend on Aether itself.

kolektiv commented 8 years ago

I think this is not a bad thing, but now i'm pondering things, what's the goal behind it? For Json.Optic.* to continue working we might need to duplicate a reasonable amount of Aether... I'm not against it, but we will retain an FParsec dependency - what's the driver for removing the Aether dependency?

neoeinstein commented 8 years ago

Yeah, we do still have that FParsec dependency… Considering that, It may be best to throw this ticket away. My main motivation was to try to remove any extraneous dependencies with the goal of being more Paket file-include friendly, but we still have other dependencies anyway. That may make this and #69 generally invalid.

kolektiv commented 8 years ago

Yeah - I think that probably makes this a lower priority - we're not realistically ever going to get to a dependency free single file, so one dependency versus two probably won't make much odds.

panesofglass commented 5 years ago

As it stands, Aether is still required in version 7, so I'm closing this for now. Please reopen if you feel it should be pursued further.