freyaMachine Decisions naming

xyncro / freya

Freya Web Stack - Meta-Package

https://freya.io

Other

330 stars 30 forks source link

freyaMachine Decisions naming #112

Open slav opened 9 years ago

slav commented 9 years ago

Just a thought. I think it would be clearer if Decisions are name to reflect that it's a decision. For example authorized sounds like an action in the past. isAuthorized sounds like a decision. Same with allowed vs isAllowed. Or it could be just not in past tense - authorize vs authorized. You kind of use that naming with "allowPostToGone".

But "is...." would be more universal. For example "isDeleted" makes sense right away. "deleted" sounds confusion. and "delete" sounds like it's a handler to delete something.

panesofglass commented 9 years ago

I'm good either way. @kolektiv?

kolektiv commented 9 years ago

I think there's some merit to this, yes, I'll put a PR together soon :)

kolektiv commented 8 years ago

OK, have been thinking, need some help!

Here's a Google Sheet to clarify, hopefully...

https://docs.google.com/spreadsheets/d/1r-h5o6Kxl_hX37NR0xq4MuPjFJQyuknIfmz7-l61tnk/edit?usp=sharing

slav commented 8 years ago

If I make make suggestions:

exists -> doesExist (sounds better than isExisting?)
existed -> didExist or hasExisted
for xxxStrict -> isStrictXxxx. e.g. encodingsStrict -> isStrictEncoding

How does this sound?

Thank you, Slava Ivanyuk

On Sun, Nov 29, 2015 at 3:37 PM, Andrew Cherry notifications@github.com wrote:

OK, have been thinking, need some help!

Here's a Google Sheet to clarify, hopefully...

https://docs.google.com/spreadsheets/d/1r-h5o6Kxl_hX37NR0xq4MuPjFJQyuknIfmz7-l61tnk/edit?usp=sharing

— Reply to this email directly or view it on GitHub https://github.com/freya-fs/freya/issues/112#issuecomment-160467837.