search

xyonico / BeatSaberSongLoader

A plugin for adding custom songs into Beat Saber
MIT License
238 stars 38 forks source link

Zip file extraction to specific folder fix #21

Closed SagsMug closed 6 years ago

SagsMug commented 6 years ago

It makes sure the files are in the hash folder in .cache without creating an additional folder It dosent fix that special characters are still broken in the Unzip library

SagsMug commented 6 years ago

I tried exchanging Unzip with .NET's own ZipArchive, it also has broken special characters

xyonico commented 6 years ago

So from testing this, all this seems to change is it doesn't create any subfolders within the hash folder. I can't accept this, because I want zips to be able to contain multiple songs, which won't work with this since it'll just extract all the song files into the same folder.

Is there some improvement to this that I'm missing?

SagsMug commented 6 years ago

no, it just seems counter intuitive to create 2 folders for each and every single song