search

xyonico / BeatSaberSongLoader

A plugin for adding custom songs into Beat Saber
MIT License
238 stars 38 forks source link

Fix'd #22

Closed Assistant closed 6 years ago

Assistant commented 6 years ago

Removed the negative BPM and NoteJumpSpeed checks.

xyonico commented 6 years ago

Instead of removing the check, it should check for if its not equal to zero. Or make the bpm and noteSpeed floats nullable and check if they are still null after going through GetBPMAndNoteJump method. This is to ensure that the bpm value in the info.json gets used if it's missing in the difficulty json.

xyonico commented 6 years ago

I'll merge and fix it myself.