xyos / horarios

MIT License
7 stars 1 forks source link

Subjects without groups #28

Open saaperezru opened 10 years ago

saaperezru commented 10 years ago

There's a problem with the front-end processing subjects that have no groups ... why are there subjects without groups on the first place!? :S ... I'll look into the SIA parser to see if I can avoid subjects without groups in the database, however this should also be handled on the front-end (if for some reason the front-end gets decoupled from the back-end)

xyos commented 10 years ago

that could be handled by the auto-complete request, isn't it? can you give an example of a subject without groups?

saaperezru commented 10 years ago

Pensamiento sistémico

xyos commented 10 years ago

the search query for it doesn't return any group, should it be on the db? by default the fetch script adds the subject to de database after the groups and professions for it are retrieved, but I didn't think in that edge case. I think it should be handled by the model, it manages the db configuration and it should raise an exception if the subject has no groups.

saaperezru commented 10 years ago

I think this should be managed on the facades level, because this makes the application reusable for other cases. For example, we could easily change our database (maybe use this for another university) and the database could have subjects without groups, which should be fine by all the level, except for the facades which avoid this subjects without groups from getting into the front-end.

What do you think?

xyos commented 10 years ago

well that will do it, I didn't think about doing it for other universities, but today I heard about a person from other university talking about our app, so yeah I think that would be the best, can you do that change?

saaperezru commented 10 years ago

I worked on changing this but this makes the search field autocomplete very slow, we may need to address this problem with a command like the one you created for deleting duplicated subjects, I'll try that instead now.