search

xyproto / wallutils

:city_sunset: Utilities for handling monitors, resolutions, wallpapers and timed wallpapers
BSD 3-Clause "New" or "Revised" License
463 stars 17 forks source link

Add support for modes for settimed #20

Closed ethanmad closed 4 years ago

ethanmad commented 4 years ago

This PR addresses my comment on https://github.com/xyproto/wallutils/issues/19#issuecomment-591623680 about modes for settimed. Based on your commit 86e7051fb209195425f5474c2993e6fdf11d8c6a.

I tried using the new modes support and it seems to work. Not specifying mode still works, too.

I don't see anything that depends on the SetTimedWallpaper or SetTimedWallpaperAction functions outside of cmd/settimed/main.go, so I think this is good to go.

While we're here, is there a particular reason stretched is the default option? Stretching doesn't look great if the aspect ratios of the image and monitor don't match. With mode support it doesn't matter, just thought it might be worthwhile discussing.

xyproto commented 4 years ago

Thanks for the pull request! It's a bit late here, so I'll look through it and merge it tomorrow. At a glance, the changes look good.

ethanmad commented 4 years ago

I fixed a missing space in the help output via force-push. Now it's good. Didn't notice the thumbs-up or comment; I hope you hadn't yet pulled this!