xyupeng / ContrastiveCrop

[CVPR 2022 Oral] Crafting Better Contrastive Views for Siamese Representation Learning
MIT License
284 stars 27 forks source link

dataloader and updating the box #7

Closed DanielaPlusPlus closed 2 years ago

DanielaPlusPlus commented 2 years ago

Hi, great work! Thank you for sharing. In the codes, training data is loaded after the contrastive crop and then is used for training through all epochs. And for every location interval epoch, the box is updated. The box is used for the contrastive crop in the data loader process to generate better sample pairs. So how is the updating of the box used for generating better sample pairs?
I guess maybe we should load the training data every time we update the box, what do you think?

xyupeng commented 2 years ago

Hi, The key is not the dataloader, but the dataset. The dataset holds the box information for every sample, which is used by ContrastiveCrop to generate better views. And the boxes are updated at some interval.

DanielaPlusPlus commented 2 years ago

How will the updated box be used for the dataset? In the codes, the dataset is loaded out of the epochs cycling with the initial box, the updating of the box is in the epochs cycling. How will the updating of the box affect the dataset?

DanielaPlusPlus commented 2 years ago

Sorry, I got it. It's solved. The updating is used here