WIP Refactor responsibilities out of WebGLPreview

xyz-tools / gcode-preview

A simple GCode parser & previewer lib with 3D printing in mind. Written in Typescript.

https://gcode-preview.web.app/

MIT License

160 stars 31 forks source link

Closed sophiedeziel closed 1 month ago

sophiedeziel commented 4 months ago

This is a POC for splitting the codebase into smaller classes

github-actions[bot] commented 4 months ago

Visit the preview URL for this PR (updated for commit 90eaa04):

_{(expires Sat, 27 Jul 2024 12:04:42 GMT)}

_{Sign: 59bd114ae4847b32c2bba0b68620b9069a3e3531}

remcoder commented 4 months ago

oh! this is a great improvement! A very neat and straightforward reorg. Very happy to see this direction 🙌🏻

remcoder commented 4 months ago

Another thing that could be split off is all the preview settings (colors, min/max layer etc).

sophiedeziel commented 4 months ago

Good idea!!

I'm using that branch as a POC, and opened a draft PR to facilitate visualization and conversations.

I'll split in smaller PRs when we're happy about some individual changes and confident about them

remcoder commented 4 months ago

And another idea might be to split line rendering and tube rendering into separate rendering classes.... ?

sophiedeziel commented 4 months ago

Of course! That's the next step!

remcoder commented 1 month ago

What do we want with this PR? It's part clean up and part parser redesign. And it has a lot of conflicts. May I propose to close this one?

sophiedeziel commented 1 month ago

Yes, let's close. The other PR is in a better state.