Fix/stats counter position

xyz-tools / gcode-preview

A simple GCode parser & previewer lib with 3D printing in mind. Written in Typescript.

https://gcode-preview.web.app/

MIT License

160 stars 31 forks source link

Fix/stats counter position #182

Closed remcoder closed 4 months ago

remcoder commented 4 months ago

changes

Adds opts.devMode.statsContainer, for passing an html element that will be the container for the stats object.
Adds the classname stats to facilitate styling.
Only instantiate the stats object when devMode is active

fixes #176

github-actions[bot] commented 4 months ago

Visit the preview URL for this PR (updated for commit 8baa2a0):

https://gcode-preview--pr182-fix-stats-counter-po-bu5gyd3b.web.app

_{(expires Mon, 29 Jul 2024 18:33:04 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 59bd114ae4847b32c2bba0b68620b9069a3e3531}

remcoder commented 4 months ago

@sophiedeziel since you've created the devMode, you might have an opinion on my changes. I was wondering if the new option (statsContainer) should be in the devMode object. And if not, wether the devMode and stats should really be separate..

sophiedeziel commented 4 months ago

No strong opinion, but I lean towards an option as part of the dev mode options.

It could be part of the devgui panels, I think that would be the best for a unified dev experience