Handle start/end layer changes gracefully

xyz-tools / gcode-preview

A simple GCode parser & previewer lib with 3D printing in mind. Written in Typescript.

https://gcode-preview.web.app/

MIT License

160 stars 31 forks source link

Handle start/end layer changes gracefully #196

Closed remcoder closed 1 month ago

github-actions[bot] commented 1 month ago

Visit the preview URL for this PR (updated for commit 6ad2fd4):

https://gcode-preview--pr196-fix-update-start-end-oi5ybhg7.web.app

_{(expires Wed, 16 Oct 2024 22:19:43 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 59bd114ae4847b32c2bba0b68620b9069a3e3531}

remcoder commented 1 month ago

Closing this as the side-effect isn't as straightforward as expected. For instance, when setting both props immediately after each other, the effect of the fist prop on the second is negated. This is problematic in scenarios where all settings are set at the same time like when using a view model object to hold settings for the UI.