search

xyz-tools / gcode-preview

A simple GCode parser & previewer lib with 3D printing in mind. Written in Typescript.
https://gcode-preview.web.app/
MIT License
160 stars 31 forks source link

Some lines are not rendered properly #216

Closed sophiedeziel closed 3 weeks ago

sophiedeziel commented 1 month ago

The only way I found to reliably reproduce is using the CNC preset, but it also happens sometimes when rendering travel lines.

Screenshot 2024-10-11 at 19 30 24

It is hard to see, but it seems like the lines are on the scene. They are just so small we can't see them. We can notice some green pixels.

remcoder commented 3 weeks ago

This might be since the bump to threejs r169. Let's check that first.

sophiedeziel commented 3 weeks ago

I tried downgrading the lib multiple times, I'm not sure it's that.

I think you should try because there is probably something I did wrong

remcoder commented 3 weeks ago

Found the problem: setting the lineWidth (thickLine) is broken when using r165+