Bring back the tolerance logic

xyz-tools / gcode-preview

A simple GCode parser & previewer lib with 3D printing in mind. Written in Typescript.

https://gcode-preview.web.app/

MIT License

160 stars 31 forks source link

Bring back the tolerance logic #224

Closed sophiedeziel closed 4 weeks ago

sophiedeziel commented 1 month ago

Part of https://github.com/remcoder/gcode-preview/issues/221

Bringing back layer tolerance for z-axis movements and added configuration options for minimum layer threshold.

Added back minLayerThreshold option to the lib options
The option is passed to the Job
The job uses it to instantiate a layer indexer with tolerance
The layer indexer has a default tolerance of 0.05 (same as before)
The indexer uses that tolerance to split the layers based on z changes

sophiedeziel commented 1 month ago

[!WARNING] This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more

#224 👈
#225 : 5 other dependent PRs (#220 , #227 , #228 and 2 others)
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sophiedeziel and the rest of your teammates on Graphite

github-actions[bot] commented 4 weeks ago

Visit the preview URL for this PR (updated for commit 3b52aaf):

https://gcode-preview--pr224-reintroduce-toleranc-1jcvwxaa.web.app

_{(expires Fri, 15 Nov 2024 03:27:11 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 59bd114ae4847b32c2bba0b68620b9069a3e3531}