xyzhangg / pe

0 stars 0 forks source link

Inconsistent behavior with setting ingredient amount to the same value #1

Open xyzhangg opened 3 years ago

xyzhangg commented 3 years ago

Say the amount of milk is 50, trying to set the amount to 50 results in an error

image.png

However I can set it to 050 as shown below

image.png

image.png

If users are not allowed to set the value to the same amount, shouldn't the second case return an error message?

nus-se-bot commented 3 years ago

Team's Response

Thank you for the bug report / question.

For this command, we have intentionally allowed the user to be able to use leading zeroes if they preferred to do so. This is different from 050 being recognised as the same as 50. 050 and 50 are different when displayed on the GUI, and thus users can use this command to choose between these two formats of display.

Furthermore, we have made this point extra clear by noting in our UG that both 07 and 007 are accepted as valid parameters for AMOUNT . This indicates that 07 and 007 are intentionally treated differently to allow for adjustment according to personal preference and the behaviour is exactly the same as the expected.

Thus, we have decided to reject this report as a bug after careful considerations.

The relevant notes is shown below:

image.png

The expected behaviour is correct, thus we have changed the bug type from functionality bug to documentation bug.

We have also decided to downgraded the severity level from medium to low because such a bug is unlikely to affect the normal operations of the product and causes only minor incovenience, instead of casuing "occasional incovenience" to users.

Screenshot 2020-11-15 at 8.42.05 PM.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]


:question: Issue type

Team chose [type.DocumentationBug] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your reason]


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your reason]