xyzz / acquisition

http://get.acquisition.today/
GNU General Public License v3.0
271 stars 100 forks source link

request for "pseudo" mods in search function #400

Open sesquipedalias opened 7 years ago

sesquipedalias commented 7 years ago

First of all, thanks for the AWESOME work!

It would be extremely useful to be able to search items with aggregate mods, like the "pseudo" mods in poe.trade; "total resistance" and "total max life" are by far the most important ones IMO.

Once again, thanks for the great software!

sesquipedalias commented 7 years ago

bump

DaneelTrevize commented 5 years ago

It would appear the attribute (str/dex/int) filters are already pseudo ones, including the values granted by "+# to all Attributes" mods. This doesn't include their affects though (life, mana, accuracy, etc).

With recent PRs being accepted w.r.t. common % and flat added damage mods, Acquisition would already support most of the pseudo category from POE's /trade form.
Adding support for total (elemental) resists doesn't seem like it would be too difficult, similarly for flat life from strength, but the official site is inconsistent w.r.t. the three attributes, not offering a pseudo category for dexterity's evasion or accuracy effects. Is there an obvious/objective set of pseudo mods to add?

DaneelTrevize commented 5 years ago

Bump for project feedback request.

sesquipedalias commented 5 years ago

hey, I hardly ever play poe anymore... On the rare occasions that I do, I still use acquisition to find things in my stash... I often have simple searches that are hard to perform: e.g. just sort items by descending sum of total (+life) + (+resistances) (including modifiers e.g. from strength)... But I'm not up to date on changes to acquisition and poe.trade... (I don't in fact know much about the current meta at all, including "new" items such as abyss jewels...)

DaneelTrevize commented 5 years ago

I was bumping more for xyzz and other contributors' feedback.

Searching by pseudo values is one thing, sorting by them would either require new static or dynamic columns to the search results, or new UI elements by each mod filter section you add via the dropdown.

ericsium commented 5 years ago

It would be nice to append mods with type [psuedo] etc... to at least indicate when a psuedo mod type. I don't think there is any objective set, it would be basically up to you.