search

xyzz / acquisition

http://get.acquisition.today/
GNU General Public License v3.0
271 stars 100 forks source link

Update windows compiler platform #405

Open ericsium opened 7 years ago

ericsium commented 7 years ago

We're still compiling with msvc 2013 32-bit component. That version doesn't have full support for c++11 specifiically constexpr. I think you were attempting to update this at some point but hit a hiccup - was it due to us using Qt 5.4 WebKit that ended up being deprecated in favor of WebEngine?

ericsium commented 7 years ago

Some notes re updates:

QT PPA's are available for precise up to 5.6.2 https://launchpad.net/~beineri

We'll need to use trusty to move QT past that or compile custom PPA's.

Looks like we'd need to transition to WebEngine as WebKit is deprecated before doing any updates.

The issue with migrating to WebEngine is that it requires MSVC 2015 compiler. So we'd have to deprecate ming compiler support and build using MSVC 2015 kit. Any issues with this?

Finally, QtTest is compiled using GCC 4.8.2 and unit tests are failing using . I'm not sure if there is any way around this other than avoiding use of in the project or recompiling custom PPA's with a later version of GCC. Deprecating use of might be the way to go but it would require use of QT's QRegularExpression library instead.

ericsium commented 7 years ago

I'm going to send a pull request shortly for this. Now that we're on trusy we have PPA's available up to QT 5.9 which is a LTS release.

https://launchpad.net/~beineri/+archive/ubuntu/opt-qt59-trusty

QT 5.9 LTS supports MSVC 2017-64 bit.

So unless there is a good reason not to it seems like we should target AT 5.9 LTS and MSVC 2017.