search

xyzz / acquisition

http://get.acquisition.today/
GNU General Public License v3.0
271 stars 100 forks source link

request for searchable mods #456

Open Torcrob opened 6 years ago

Torcrob commented 6 years ago

still cant look up items by the crit multi mod and would it be nice if enchants could be searched aswell and jewels would be great too

DaneelTrevize commented 5 years ago

Jewels can already be searced for (though without support for specifically Abyssal jewels atm).
Crit multi is resolved as per PR #493.
Enchants as a does-or-does-have-any filter are supported in PR #500.

Do we want to somehow try make every known enchant searchable? Or at least try add a filter for Normal/Cruel/Merciless/"Uber" tier, even though iirc that's not specified by the API and only easily detectable for Word/Edict/Decree/Commandment-type enchants (i.e. not generic or skill gem specific ones).

Do we want to add a Type sub-category for Abyss jewels?

DaneelTrevize commented 5 years ago

Bump for project feedback request.

DaneelTrevize commented 5 years ago

Jewels.Abyss were added as a type in 0.8.

Close this issue for lack of interest in searching each & every kind of enchant specifically?

Torcrob commented 5 years ago

tbh im quite out of the loop, as i am not actively playing much atm. the request for the crit multi and jewelmod searches was for the mod-dropdown list. the enchant search request, in my mind, would have worked like the searchbar in PoB for uniques. (not a programmer, nor english mothertongue so pardon my choice of words) the idea is to have the searchbar in the top left parse the items entire modificationslist and not just its name for a matching string. this would allow the results of a "barrage" search to show enchanted helmets aswell as skillgems or volleyfire jewels etc.. this would also allow us to search new mods like "focus" by just its name, no pre-setup dropdownlist required. i do see that this would increase the amount of required work per searchrequest drasticly and i do not know if its even reasonable/possible to implement in the current programm.

an easy and quick fix would be to give us a toggle "enchanted" option, that with choosing a base type should narrow down most searches to a managable amount of results, atleast in most stashes.

thanks for the work u guys r doin for the community do i close the issue or who?