DaneelTrevize
commented
5 years ago This has been rebased again to avoid conflicts, and should be ready to be pulled.
Closed DaneelTrevize closed 5 years ago
DaneelTrevize
commented
5 years ago This has been rebased again to avoid conflicts, and should be ready to be pulled.
Correct the unifying label width mechanism, for "Map Tier" being longer than "R. Level". Zana's new signature mod is very verbosely worded. The QCompleter mods dropdown forces the min-width of the search UI to the longest mod string in the list. So I replaced a few Master mods with* prefixed shorter names. More experience with Qt would be required to possibly find a way to alter the popup's width behaviour via QAbstractItemView, and/or styling these placeholder mod lines (e.g. with italics). Fix use of disable_login bool for certain Login DisplayErrors. Add support for "% Increased Attack and Cast speed" mod (found on jewels), increased spell base crit chance, and % maximum life. Subjectively improved the order of mods in the dropdown filter. Tidy some declaration orders, NULL pointers, unused parameters to reduce warnings. Remove the last reference to cosmeticMods, from old MTX support. Code style tweaks as suggested.
Addresses issue #496 , wants to be merged after PR #502 , will still likely conflict because this branch is not a chained one from that and doing things this way prevents git from knowing how to handle column/property insertion order, but keeps individual PRs initially cleaner.