Graphical support for War for the Atlas (Shaper/Elder) item varients

xyzz / acquisition

http://get.acquisition.today/

GNU General Public License v3.0

270 stars 100 forks source link

Graphical support for War for the Atlas (Shaper/Elder) item varients #504

Closed DaneelTrevize closed 5 years ago

DaneelTrevize commented 5 years ago

New function for generating either header side. Scales overlay. Slight difference/transition to central header background. Not yet made to exactly match online/in-game versions.

Add in a shaper/elder background layer to the item image, if of that type. Add new war background image resources. Newer copies of GGG's web view 2D header art.

Addresses issue #490

Examples of 1 and 2 line shaper and elder backgrounds & header side icon overlays.

xyzz commented 5 years ago

You should rename the files so that there's no whitespace, otherwise it's hitting https://bugreports.qt.io/browse/QTBUG-48919

DaneelTrevize commented 5 years ago

I didn't have that problem, I invoked qmake from the QtCreator menu, and it works. But ok, can do.

One afterthought I had was re: the naming of the function and usage of the *ui parameter. Would it be cleaner to have header_size defined outside, the function take that instead of ui, and to actually return the generated pixmap rather than set it internally (to avoid side effects, make it a more pure function)? But then, the same could be said of GenerateItemIcon(), and maybe GenerateItemTooltip()...