search

xyzz / acquisition

http://get.acquisition.today/
GNU General Public License v3.0
270 stars 100 forks source link

Improve categories #507

Closed DaneelTrevize closed 5 years ago

DaneelTrevize commented 5 years ago

Disable PoB export button, so other changes can be accepted. Reached feature parity with previous category approach. Define an Item Wearable function, and use it to control PoB export button. Remove old category name mappings. Refactor around Item baseType, constants, function calls. Don't draw a socket layer if there aren't any sockets. Factor out some magic numbers. More intuitive painter image name. Cleaner switch statements rather than recreate a small set of paths. Add "Copy for Path of Building" button and grouping widget to UI.

DaneelTrevize commented 5 years ago

I'm used to different style guidelines w.r.t. using spaces to make things more human-friendly, and avoiding polluting scopes with used-once variables, but it's your codebase to maintain, and apologies where I slip between & mix the different styles as I either get into a flow or revert to referencing other sections.

DaneelTrevize commented 5 years ago

I'm not sure if you were already notified of the commit earlier that resolved your change requests, but this is to hopefully ping you that it's ready.

xyzz commented 5 years ago

there's still a bunch of if( that should be if (

DaneelTrevize commented 5 years ago

Adjusted, as well as a last few for(s found elsewhere. I'm not touching the 8710 occurances of if( in sqlite3.c, naturally.

DaneelTrevize commented 5 years ago

FWIW, I asked a few questions around this icon path parsing approach to GGG, and had a response from Rory.

https://www.reddit.com/r/pathofexiledev/comments/a1jnoy/apiwebcdn_question_around_map_icons/