search

xyzz / openmw-android

OpenMW for Android
https://omw.xyz.is/
GNU General Public License v3.0
325 stars 87 forks source link

Touch joysticks have issues with maintaining boundaries #63

Open onceagainifindmyselfhere opened 3 years ago

onceagainifindmyselfhere commented 3 years ago

Describe the bug A clear and concise description of what the bug is.

If you put your thumb down on the movement stick and move forward and then put your other thumb on the look stick, they will both register the touch, so your movement will immediately be pulled to the right (or left if sticks are reversed) but you'll keep looking forward. Adjust for it without taking thumbs off, then try to interact with an object using your right thumb (or left) and your vision will, in one frame, be immediately facing the opposite direction, the right joystick having understood your left thumb on the left joystick as being a touch on the right joystick.

Makes the game essentially unplayable with touch screen controls

To Reproduce Steps to reproduce the behavior:

What I described.

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

I expected to be able to move and look without my movement and looking being improperly tied to the wrong joysticks

Screenshots If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

licaon-kter commented 3 years ago

I think I see this often too.

xyzz commented 3 years ago

cannot reproduce on pixel 1

Laezhesto commented 3 years ago

Same issue on s10+ exynos after updating to android 11

onceagainifindmyselfhere commented 3 years ago

Sooooo. Many. Touch issues with Android 11 in general and mouse function is all but broken in everything except OMW ironically

On Tue, Feb 2, 2021, 8:00 AM Laezhesto notifications@github.com wrote:

Same issue on s10+ exynos after updating to android 11

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/xyzz/openmw-android/issues/63#issuecomment-771618029, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR7K65GODGQFSL6OSV4CLSTS47ZPLANCNFSM4W3YKRWA .

JFrostNC commented 3 years ago

I am having the exact same issue on Samsung Galaxy Z Fold2 with Android 11. Actually signed up just so I could post this problem.

JFrostNC commented 3 years ago

Just an update from me: I discovered that I have the issue when using the Nightly build, but using the current OMW from the Playstore does not have this problem; the control sticks work fine.

licaon-kter commented 3 years ago

@JFrostNC how old is that?

JFrostNC commented 3 years ago

@licaon-kter how old is what? The version that works is 0.46.0-38. The Nightly build (that has the issue) is 0.47.0-41-nightly

xyzz commented 3 years ago

so I tried reproducing this using samsung remote device lab, out of like 10 devices only 5 I was able to connect to and then only 1 of these had working adb, and the issue didn't reproduce on it, perhaps due to different touch handling :/

onceagainifindmyselfhere commented 3 years ago

Just noticed this too but whats weird is that i had the play store version when i initially noticed it. I uninstalled, installed several other builds, then finally relented and hoped the play store reinstall would work. 🤷 It did. Is it possible this isnt just my imagination?

On Sat, Feb 6, 2021, 11:42 AM JFrostNC notifications@github.com wrote:

Just an update from me: I discovered that I have the issue when using the Nightly build, but using the current OMW from the Playstore does not have this problem; the control sticks work fine.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/xyzz/openmw-android/issues/63#issuecomment-774504745, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR7K65ERUGVNQCDOYWHLICLS5VWNVANCNFSM4W3YKRWA .

xyzz commented 3 years ago

Ok, can you go through nightly releases at https://github.com/xyzz/openmw-android/releases (marked with -nightly) and let me know which is the earliest version that has the issue.

JFrostNC commented 3 years ago

None of them have the problem for me anymore, including the latest version. I don't know if uninstalling/ re-installing did the trick, or what. I haven't changed or updated anything else.

Sorry it took so long for me to check!

licaon-kter commented 3 years ago

Is this the issue or should I open a new one?

https://user-images.githubusercontent.com/2282799/107860561-cad2c780-6e37-11eb-8a9f-478e416e9f59.mp4

onceagainifindmyselfhere commented 3 years ago

It's a different issue, I'll try to install one of the old apks and replicate it.

On Sat, Feb 13, 2021, 3:13 PM Licaon_Kter notifications@github.com wrote:

Is this the issue or should I open a new one?

https://user-images.githubusercontent.com/2282799/107860561-cad2c780-6e37-11eb-8a9f-478e416e9f59.mp4

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/xyzz/openmw-android/issues/63#issuecomment-778671946, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR7K65CNRHV2ISYMZZE6M6DS63MORANCNFSM4W3YKRWA .

licaon-kter commented 3 years ago

@onceagainifindmyselfhere

in one frame, be immediately facing the opposite direction, the right joystick having understood your left thumb on the left joystick as being a touch on the right joystick.

This happens in the actual video at 00:14.

onceagainifindmyselfhere commented 3 years ago

Also, it had stopped, it's happening again. A config file conflict or something maybe? I'm not noticing a mod connection

On Mon, Feb 15, 2021, 9:43 PM mark stevens realitynowassigned@gmail.com wrote:

I'll have to rewatch I was probably misinterpreting what was going on but if it's this then yeah

On Sat, Feb 13, 2021, 6:40 PM Licaon_Kter notifications@github.com wrote:

@onceagainifindmyselfhere https://github.com/onceagainifindmyselfhere

in one frame, be immediately facing the opposite direction, the right joystick having understood your left thumb on the left joystick as being a touch on the right joystick.

This happens in the actual video...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/xyzz/openmw-android/issues/63#issuecomment-778694114, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR7K65GATQX4XZH7ZWZUEK3S64EW5ANCNFSM4W3YKRWA .

Sisah2 commented 3 years ago

I think it alwais happened, at least on my note 8,9,10. Worst it is when using bow, on borderless phone accidentaly touching lower right corner result in shooting to ground after releasing attack button.

HighDarkElf commented 3 years ago

It must be the android 11 update as it used to work on android 10 fine. I have the exact same files and config in a lesser oppo phone and that runs everything fine tried wiping config and adjusting settings also installed the nightly version and tried on that with the same problem replicated. Move left stick and touch right stick = unwarranted right strafe move right stick and touch left = unwarranted 180 flick of view. The combination makes the application unusable

Sisah2 commented 3 years ago

Maybe we speaking about different issue, im speaking about if you look up still hold that button and touch somewhere else (bottom) on the screen, then release that finger you used to look, the view jump to diferent position as if you moved your "look" finger to position of second finger.

Android 10 here.

agung0k commented 3 years ago

Android 11 have same issue. camera touch affecting the movement touch when used at the same time. resulting in drifting to the right.

xyzz commented 3 years ago

What is your device?

HighDarkElf commented 3 years ago

What is your device?

I have Samsung galaxy s10 lite.

A temporary bypass to use the game I've found is to connect a Bluetooth controller like a ps or xbox controller.

agung0k commented 3 years ago

What is your device?

Samsung Galaxy A52

Vikutomaru commented 3 years ago

Same issue with Android 11 with OneUI 3.1 (recently updated) on my Samsung Tab S6 - camera view jumps 90 degrees downwards while holding viewing touch control and touching on the movement touch control circle. The same occurs while holding attack button (with weapon ready) and touching on the movement touch control circle. Furthermore, when holding a direction with the movement touch control and simultaneously holding the viewing touch control, my movement would drift to the right. This is abolised by dragging my movement touch control point to above the midpoint of the screen, which makes it tricky for navigation during combat. Otherwise, there is no issue when using bluetooth controller or mouse + keyboard. FYI, the above issue was not present with Android 10 on my tab previously.

notsodorp commented 3 years ago

Pls fix

onceagainifindmyselfhere commented 3 years ago

Still present on the nightly build but stable claims not to be compatible with my device anymore

On Wed, Apr 21, 2021, 10:48 AM notsodorp @.***> wrote:

Pls fix

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/xyzz/openmw-android/issues/63#issuecomment-824121451, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR7K65FSC455PEZD2MY7233TJ3QTPANCNFSM4W3YKRWA .

xyzz commented 3 years ago

Yes, as mentioned in the linked issue #92

Samsung devices which received android 11 update were manually excluded due to #63

Basically, Samsung broke/changed something wrt touch controls in 11 (which is not reproducible on other manufacturers' devices), and samsung users were posting a lot of 1-star reviews due to controls not working properly, so it's temporarily excluded.

Unfortunately I don't have any samsung devices so at the moment I cannot reproduce or fix the bug.

onceagainifindmyselfhere commented 3 years ago

Samsung and google really fucked up after the s9. This phone is unbelievably powerful and feels every day like a more expensive brick. I feel bad for it. For the people who made it. It's like cutting a bird's wings off.

I'd like to, shortly into the future, donate to the cause specifically to a used device that can replicate the issue. How much would it be

On Mon, Sep 6, 2021, 9:37 PM xyzz @.***> wrote:

Yes, as mentioned in the linked issue #92 https://github.com/xyzz/openmw-android/issues/92

Samsung devices which received android 11 update were manually excluded due to #63 https://github.com/xyzz/openmw-android/issues/63

Basically, Samsung broke/changed something wrt touch controls in 11 (which is not reproducible on other manufacturers' devices), and samsung users were posting a lot of 1-star reviews due to controls not working properly, so it's temporarily excluded.

Unfortunately I don't have any samsung devices so at the moment I cannot reproduce or fix the bug.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/xyzz/openmw-android/issues/63#issuecomment-913928791, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR7K65CTBMHAJ36NOWFSERLUAVUE5ANCNFSM4W3YKRWA .