search

xyzz / openmw-android

OpenMW for Android
https://omw.xyz.is/
GNU General Public License v3.0
325 stars 87 forks source link

Grass instancing #64

Closed pulion closed 3 years ago

pulion commented 3 years ago

xyzz, please add grass instancing to your future builds.

xyzz commented 3 years ago

not sure what does that mean? Is there a configuration option?

pulion commented 3 years ago

not sure what does that mean? Is there a configuration option?

https://github.com/OpenMW/openmw/pull/3023

docent27 commented 3 years ago

This herb has long been merged into the master branch. The problem now is that it is impossible to build the APK on a fresh commit without errors in the log file.

xyzz commented 3 years ago

if it was merged then it will be added to the next build. No need to open an issue about it.

Sisah2 commented 3 years ago

I know its closed, but best would be revert grass instancing and merge grass paging by akortunov, it work much much faster on android, because gl4es dont support instancing properly, it only emulating it.

https://github.com/akortunov/openmw/tree/grass_paging

Would it be possible to revert it automatically and merge paging throught buildscripts?

docent27 commented 3 years ago

I have no difficulty with the grass that is currently in the MASTER branch.

Sisah2 commented 3 years ago

It work without visual bugs, but main reason why it was made is improve performance, which it dont do (it run slower than loading grass as regular mod) but paging is basicaly the same and also improve performance a lot.

pulion commented 3 years ago

when comparing an APK file with grass instancing versus grass paging support, there really was a difference in favor of grass paging. I don’t feel the difference now. perhaps this is due to the capabilities of the new smartphone. but I would gladly do again comparative tests on new APK files with the same settings, if there was such a possibility.

Sisah2 commented 3 years ago

Well, there is huge difference.

Sisah2 commented 3 years ago

Its simple. Instancing. Screenshot_20210228-150828_OMW Nightly Paging Screenshot_20210228-150908_OMW (Debug)

xyzz commented 3 years ago

Would it be possible to revert it automatically and merge paging throught buildscripts?

It's too much work for me to maintain such a large patch, if there are performance issues you should bring them up with openmw team and get it fixed in openmw master.