search

xyzz / openmw-android

OpenMW for Android
https://omw.xyz.is/
GNU General Public License v3.0
325 stars 87 forks source link

Some notes before updating OpenMW #88

Closed AbduSharif closed 3 years ago

AbduSharif commented 3 years ago

There has been alot of changes to OpenMW since the last update and it seems it broke some patches including: https://github.com/xyzz/openmw-android/blob/master/buildscripts/patches/openmw/0014-settingswindow-save-user-settings-file-when-ok-is-pr.patch

(As of 4 days ago the patch was updated)

Also this feature has been introduced: https://gitlab.com/OpenMW/openmw/-/issues/5500 It also solves some issues where nav mesh generation wasn't fast enough to cover areas around the player on Android devices (mostly) and that made some issues appear like: https://gitlab.com/OpenMW/openmw/-/issues/5573

But as a trade off of the feature, loading screens might take a long time on those devices so it was suggested to change "max tiles number =" value to 50 in the settings-default.cfg patch as a workaround, this comment shows how it helps: https://gitlab.com/OpenMW/openmw/-/merge_requests/819#note_568285548

AbduSharif commented 3 years ago

The feature has been merged to the OpenMW master branch: https://gitlab.com/OpenMW/openmw/-/commit/fd89582e0ce20523e6c3f96a96540c3ec8526b2a

xyzz commented 3 years ago

the patch was updated 4 days ago, is it still broken?

AbduSharif commented 3 years ago

Oh I haven't tried that actually (and haven't seen it), I wasn't aware of the recent changes here. I'll update this issue.

AbduSharif commented 3 years ago

It's not broken with latest master.

Sisah2 commented 3 years ago

Seems like there is crash when using cyrilic encoding and clicking on options in journal when using sdk21

xyzz commented 3 years ago

see https://github.com/xyzz/openmw-android/issues/89#issuecomment-841670541 re: the last comment

AbduSharif commented 3 years ago

So it turns out most of the waiting time was a bug, fixed in: https://gitlab.com/OpenMW/openmw/-/merge_requests/861

It has been merged.

AbduSharif commented 3 years ago

It's now recommend to use "wait until min distance to player = " 3 or 4.

Still reducing "max tiles number = " value to something like 256 should help performance on Android devices especially when using a heavily modded setup in my testing.

AbduSharif commented 3 years ago

This MR (which has been merged recently) also broke how OpenMW android handles settings-default.cfg: https://gitlab.com/OpenMW/openmw/-/merge_requests/822

xyzz commented 3 years ago

should all be resolved